-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide AppGroup directory as location for iOS #75
base: cordova-sqlite-ext-2.x
Are you sure you want to change the base?
Provide AppGroup directory as location for iOS #75
Conversation
Thanks @be-ndee for the nice contribution. In general I like the way this enhancement was coded. That said, I would probably rework it in one of the following ways:
For the second alternative there should probably be another plugin to lookup the directory path URL, based on the shared group ID. |
P.S. Some alternatives how to get Cordova app preferences from config.xml now tracked in brodycj/cordova-notes#2
|
I've added some changes. I removed the "Shared" location and provided a new option called |
Thanks @be-ndee for what looks like a wonderful contribution. I will probably need 1-2 weeks to test and integrate due to some other, pressing issues. |
…a-sqlite-ext into cordova-sqlite-ext-master
@brodybits what's the current progress of this pr? |
It may be another 1-2 months due to some client support needs and other pressing issues. My apologies. |
Please feel free to maintain and publish your own fork until I get a chance to deal with this one. I will likely support the arbitrary database location for all 3 mobile platforms Android/iOS/Windows at the same time, in a new major release. |
Thanks for the fast reply, you don't need to apologize. Just wanted to know, what's up at the moment ;) Good idea to do it in a major release, which is more tested and not a fast-fix, like I did it ;) Thank you anyway! :) |
This changes provide a new iOS Location called "Shared" which uses the AppGroup-ID to access a shared directory. If you set the
iosDatabaseLocation
toShared
and you set the preferenceSqliteExtAppGroupId
in theconfig.xml
to your AppGroup-ID, than the database can be used in the shared directory for your AppGroup.I have to admit, that this is a very "fast" and simple way of adding this functionality, so I'm not sure if it's the right way. But it's working for me and I need it in a project.